Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
57 | 0 | 0 | 517 |
Files
org/saf/struts/SafPlugin.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| 'static' modifier out of order with the JLS suggestions. |
19
|
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
19
|
| Method 'destroy' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Line is longer than 80 characters. |
31
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Parameter actionServlet should be final. |
34
|
| Parameter moduleConfig should be final. |
34
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
43
|
org/saf/struts/SafRequestProcessor.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
23
|
| Missing a Javadoc comment. |
23
|
| Parameter actionServlet should be final. |
23
|
| Parameter moduleConfig should be final. |
23
|
| Method 'processActionPerform' is not designed for extension - needs to be abstract, final or empty. |
30
|
| Missing a Javadoc comment. |
30
|
| Parameter request should be final. |
30
|
| Parameter response should be final. |
31
|
| Parameter action should be final. |
31
|
| Parameter form should be final. |
31
|
| Parameter mapping should be final. |
32
|
| Line is longer than 80 characters. |
45
|
| Line contains a tab character. |
45
|
org/saf/struts/SafTilesRequestProcessor.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
23
|
| Missing a Javadoc comment. |
23
|
| Parameter actionServlet should be final. |
23
|
| Parameter moduleConfig should be final. |
23
|
| Method 'processActionPerform' is not designed for extension - needs to be abstract, final or empty. |
30
|
| Missing a Javadoc comment. |
30
|
| Parameter request should be final. |
30
|
| Parameter response should be final. |
31
|
| Parameter action should be final. |
31
|
| Parameter form should be final. |
31
|
| Parameter mapping should be final. |
32
|
| Line is longer than 80 characters. |
44
|
| Line contains a tab character. |
44
|
org/saf/struts/bean/AuthorizationAction.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
7
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Method 'setAuthorizationDefinitionId' is not designed for extension - needs to be abstract, final or empty. |
22
|
| Parameter authorizationDefinitionId should be final. |
22
|
| 'authorizationDefinitionId' hides a field. |
22
|
| Method 'getAuthorizationDefinitionId' is not designed for extension - needs to be abstract, final or empty. |
29
|
| Method 'setAuthorizationErrorForwardId' is not designed for extension - needs to be abstract, final or empty. |
37
|
| Parameter authorizationErrorForwardId should be final. |
38
|
| 'authorizationErrorForwardId' hides a field. |
38
|
| Method 'getAuthorizationErrorForwardId' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Method 'setAuthorizationMethodMap' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Parameter authorizationMethodMap should be final. |
52
|
| 'authorizationMethodMap' hides a field. |
52
|
| Method 'getAuthorizationMethodMap' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Parameter type should be final. |
66
|
| 'type' hides a field. |
66
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Method 'addAuthorizationMethod' is not designed for extension - needs to be abstract, final or empty. |
77
|
| Missing a Javadoc comment. |
77
|
| Parameter method should be final. |
77
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
88
|
org/saf/struts/bean/AuthorizationDefinition.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
10
|
| Method 'setDefinitionMap' is not designed for extension - needs to be abstract, final or empty. |
15
|
| Parameter definitionMap should be final. |
15
|
| 'definitionMap' hides a field. |
15
|
| Method 'getDefinitionMap' is not designed for extension - needs to be abstract, final or empty. |
22
|
| Method 'setExtendsAuthorizationDefinitionId' is not designed for extension - needs to be abstract, final or empty. |
30
|
| Parameter extendsAuthorizationDefinitionId should be final. |
31
|
| 'extendsAuthorizationDefinitionId' hides a field. |
31
|
| Line is longer than 80 characters. |
32
|
| Method 'getExtendsAuthorizationDefinitionId' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Method 'setRefId' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Parameter refId should be final. |
45
|
| 'refId' hides a field. |
45
|
| Method 'getRefId' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Method 'addAllDefinitions' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Missing a Javadoc comment. |
56
|
| Parameter definitionMap should be final. |
56
|
| 'definitionMap' hides a field. |
56
|
| Line contains a tab character. |
58
|
| Method 'addDefinition' is not designed for extension - needs to be abstract, final or empty. |
64
|
| Missing a Javadoc comment. |
64
|
| Parameter definition should be final. |
64
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
75
|
| Line is longer than 80 characters. |
82
|
| Avoid inline conditionals. |
82
|
org/saf/struts/bean/AuthorizationErrorForward.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
4
|
| Missing a Javadoc comment. |
5
|
| Method 'setForwardName' is not designed for extension - needs to be abstract, final or empty. |
10
|
| Parameter forwardName should be final. |
10
|
| 'forwardName' hides a field. |
10
|
| Method 'getForwardName' is not designed for extension - needs to be abstract, final or empty. |
17
|
| Method 'setRefId' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Parameter refId should be final. |
24
|
| 'refId' hides a field. |
24
|
| Method 'getRefId' is not designed for extension - needs to be abstract, final or empty. |
31
|
org/saf/struts/bean/AuthorizationManager.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
12
|
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
17
|
| Parameter type should be final. |
17
|
| 'type' hides a field. |
17
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
31
|
org/saf/struts/bean/AuthorizationMethod.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
4
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
6
|
| Method 'setAuthorizationDefinitionId' is not designed for extension - needs to be abstract, final or empty. |
11
|
| Parameter authorizationDefinitionId should be final. |
11
|
| 'authorizationDefinitionId' hides a field. |
11
|
| Method 'getAuthorizationDefinitionId' is not designed for extension - needs to be abstract, final or empty. |
18
|
| Method 'setAuthorizationErrorForwardId' is not designed for extension - needs to be abstract, final or empty. |
26
|
| Parameter authorizationErrorForwardId should be final. |
27
|
| 'authorizationErrorForwardId' hides a field. |
27
|
| Method 'getAuthorizationErrorForwardId' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Parameter name should be final. |
41
|
| 'name' hides a field. |
41
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
48
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
55
|
org/saf/struts/bean/AuthorizationPutDefinition.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
19
|
| Parameter name should be final. |
19
|
| 'name' hides a field. |
19
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
26
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
33
|
| Parameter value should be final. |
33
|
| 'value' hides a field. |
33
|
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Parameter o should be final. |
47
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
61
|
| Parameter o should be final. |
61
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
72
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
83
|
org/saf/struts/bean/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/saf/struts/config/StrutsAuthorizationConfig.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
| First sentence should end with a period. |
29
|
| Method 'getAuthorizationActionMap' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Method 'getAuthorizationDefinitionMap' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Method 'setAuthorizationErrorForward' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Parameter authorizationErrorForward should be final. |
55
|
| 'authorizationErrorForward' hides a field. |
55
|
| Method 'getAuthorizationErrorForward' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Method 'getAuthorizationErrorForwardMap' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Method 'setAuthorizationManager' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Parameter authorizationManager should be final. |
77
|
| 'authorizationManager' hides a field. |
77
|
| Method 'getAuthorizationManager' is not designed for extension - needs to be abstract, final or empty. |
84
|
| Method 'addAuthorizationAction' is not designed for extension - needs to be abstract, final or empty. |
88
|
| Missing a Javadoc comment. |
88
|
| Parameter action should be final. |
88
|
| Method 'addAuthorizationDefinition' is not designed for extension - needs to be abstract, final or empty. |
96
|
| Missing a Javadoc comment. |
96
|
| Parameter definition should be final. |
96
|
| Line is longer than 80 characters. |
104
|
| Method 'addAuthorizationErrorForward' is not designed for extension - needs to be abstract, final or empty. |
104
|
| Missing a Javadoc comment. |
104
|
| Parameter forward should be final. |
104
|
| Method 'readConfig' is not designed for extension - needs to be abstract, final or empty. |
112
|
| Missing a Javadoc comment. |
112
|
| Parameter is should be final. |
112
|
| Line is longer than 80 characters. |
123
|
| Line is longer than 80 characters. |
127
|
| Line is longer than 80 characters. |
130
|
| Line is longer than 80 characters. |
133
|
| Line is longer than 80 characters. |
134
|
| Line is longer than 80 characters. |
137
|
| Line is longer than 80 characters. |
141
|
| Line is longer than 80 characters. |
143
|
| Line is longer than 80 characters. |
147
|
| Line is longer than 80 characters. |
149
|
| Line is longer than 80 characters. |
152
|
| Line is longer than 80 characters. |
156
|
| Line is longer than 80 characters. |
158
|
| Line is longer than 80 characters. |
160
|
| Line is longer than 80 characters. |
164
|
| Line is longer than 80 characters. |
166
|
| Line is longer than 80 characters. |
168
|
| Missing a Javadoc comment. |
181
|
| Parameter authorizationDefinition should be final. |
182
|
| Parameter mainAuthorizationDefinition should be final. |
183
|
| '&&' should be on a new line. |
184
|
| Line is longer than 80 characters. |
186
|
| '&&' should be on a new line. |
189
|
| Line is longer than 80 characters. |
190
|
| Line is longer than 80 characters. |
191
|
| Line is longer than 80 characters. |
192
|
| Missing a Javadoc comment. |
199
|
| Line is longer than 80 characters. |
201
|
| Line is longer than 80 characters. |
206
|
| Line is longer than 80 characters. |
208
|
| Line is longer than 80 characters. |
209
|
| Line is longer than 80 characters. |
210
|
| Line is longer than 80 characters. |
212
|
org/saf/struts/config/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/saf/struts/exception/SafAuthorizationException.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
13
|
| Line is longer than 80 characters. |
20
|
| Parameter msg should be final. |
29
|
| Parameter throwable should be final. |
29
|
| Parameter msg should be final. |
38
|
| Parameter throwable should be final. |
47
|
org/saf/struts/exception/SafElementAlreadyExistException.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
7
|
| Parameter msg should be final. |
22
|
| Parameter throwable should be final. |
22
|
| Parameter msg should be final. |
31
|
| Parameter throwable should be final. |
40
|
org/saf/struts/exception/SafException.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
7
|
| Parameter msg should be final. |
22
|
| Parameter throwable should be final. |
22
|
| Parameter msg should be final. |
31
|
| Parameter throwable should be final. |
40
|
org/saf/struts/exception/SafPrincipalException.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
13
|
| Line is longer than 80 characters. |
20
|
| Parameter msg should be final. |
29
|
| Parameter throwable should be final. |
29
|
| Parameter msg should be final. |
38
|
| Parameter throwable should be final. |
47
|
org/saf/struts/exception/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/saf/struts/manager/AuthorizationManagerInterface.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
26
|
| Line is longer than 80 characters. |
30
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
34
|
org/saf/struts/manager/BasicAuthorizationManager.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
26
|
| Missing a Javadoc comment. |
26
|
| Line is longer than 80 characters. |
27
|
| Missing a Javadoc comment. |
27
|
| 'static' modifier out of order with the JLS suggestions. |
27
|
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
27
|
| Missing a Javadoc comment. |
28
|
| 'static' modifier out of order with the JLS suggestions. |
28
|
| Missing a Javadoc comment. |
29
|
| 'static' modifier out of order with the JLS suggestions. |
29
|
| Line is longer than 80 characters. |
32
|
| Method 'isAuthorized' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Parameter action should be final. |
38
|
| Parameter mapping should be final. |
38
|
| Parameter form should be final. |
39
|
| Parameter request should be final. |
39
|
| Parameter response should be final. |
40
|
| Line is longer than 80 characters. |
56
|
| '+' should be on a new line. |
61
|
| Line is longer than 80 characters. |
69
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
73
|
| Line is longer than 80 characters. |
85
|
| Line is longer than 80 characters. |
106
|
| Method 'doAfterAuthorization' is not designed for extension - needs to be abstract, final or empty. |
112
|
| Parameter action should be final. |
112
|
| Parameter mapping should be final. |
112
|
| Parameter form should be final. |
113
|
| Parameter request should be final. |
113
|
| Parameter response should be final. |
114
|
| Line is longer than 80 characters. |
120
|
| Method 'doAfterAuthorizationFailed' is not designed for extension - needs to be abstract, final or empty. |
126
|
| Parameter action should be final. |
126
|
| Parameter mapping should be final. |
127
|
| Parameter form should be final. |
127
|
| Parameter request should be final. |
127
|
| Parameter response should be final. |
128
|
| Line is longer than 80 characters. |
142
|
| Method 'doBeforeAuthorization' is not designed for extension - needs to be abstract, final or empty. |
148
|
| Parameter action should be final. |
148
|
| Parameter mapping should be final. |
148
|
| Parameter form should be final. |
149
|
| Parameter request should be final. |
149
|
| Parameter response should be final. |
150
|
org/saf/struts/manager/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/saf/struts/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/saf/struts/taglib/AuthorizedTag.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
22
|
| Method 'setDefId' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Parameter defId should be final. |
27
|
| 'defId' hides a field. |
27
|
| Method 'condition' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Method 'condition' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter desired should be final. |
38
|
| Line is longer than 80 characters. |
39
|
org/saf/struts/taglib/NotAuthorizedTag.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
15
|
| Method 'condition' is not designed for extension - needs to be abstract, final or empty. |
20
|
org/saf/struts/taglib/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/saf/struts/util/Constants.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Line is longer than 80 characters. |
4
|
| Missing a Javadoc comment. |
4
|
| 'static' modifier out of order with the JLS suggestions. |
4
|
| Line is longer than 80 characters. |
5
|
| Missing a Javadoc comment. |
5
|
| 'static' modifier out of order with the JLS suggestions. |
5
|
org/saf/struts/util/Globals.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
4
|
| Line is longer than 80 characters. |
5
|
| Line contains a tab character. |
5
|
| Missing a Javadoc comment. |
5
|
org/saf/struts/util/HashCodeUtil.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
9
|
| Line has trailing spaces. |
10
|
| Line has trailing spaces. |
11
|
| Utility classes should not have a public or default constructor. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
| Name 'fODD_PRIME_NUMBER' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
27
|
| Missing a Javadoc comment. |
29
|
| Parameter seed should be final. |
29
|
| Parameter aObject should be final. |
29
|
| Missing a Javadoc comment. |
48
|
| Parameter seed should be final. |
48
|
| Parameter aBoolean should be final. |
48
|
| Avoid inline conditionals. |
49
|
| Missing a Javadoc comment. |
52
|
| Parameter seed should be final. |
52
|
| Parameter aChar should be final. |
52
|
| Missing a Javadoc comment. |
56
|
| Parameter seed should be final. |
56
|
| Parameter aInt should be final. |
56
|
| Missing a Javadoc comment. |
60
|
| Parameter seed should be final. |
60
|
| Parameter aLong should be final. |
60
|
| '32' is a magic number. |
61
|
| Missing a Javadoc comment. |
64
|
| Parameter seed should be final. |
64
|
| Parameter aFloat should be final. |
64
|
| Missing a Javadoc comment. |
68
|
| Parameter seed should be final. |
68
|
| Parameter aDouble should be final. |
68
|
| Missing a Javadoc comment. |
72
|
| Parameter aObject should be final. |
72
|
| Missing a Javadoc comment. |
76
|
| Parameter seed should be final. |
76
|
org/saf/struts/util/RequestProcessorUtils.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
25
|
| Line is longer than 80 characters. |
26
|
| Missing a Javadoc comment. |
26
|
| 'static' modifier out of order with the JLS suggestions. |
26
|
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
26
|
| Missing a Javadoc comment. |
27
|
| Missing a Javadoc comment. |
29
|
| Parameter actionServlet should be final. |
29
|
| Parameter moduleConfig should be final. |
30
|
| Line is longer than 80 characters. |
38
|
| Line is longer than 80 characters. |
46
|
| Line is longer than 80 characters. |
47
|
| Line is longer than 80 characters. |
48
|
| Method 'isAuthorized' is not designed for extension - needs to be abstract, final or empty. |
64
|
| Missing a Javadoc comment. |
64
|
| Parameter action should be final. |
64
|
| Parameter mapping should be final. |
64
|
| Parameter form should be final. |
65
|
| Parameter request should be final. |
65
|
| Parameter response should be final. |
66
|
| Method 'doAfterAuthorization' is not designed for extension - needs to be abstract, final or empty. |
77
|
| Missing a Javadoc comment. |
77
|
| Parameter action should be final. |
77
|
| Parameter mapping should be final. |
77
|
| Parameter form should be final. |
78
|
| Parameter request should be final. |
78
|
| Parameter response should be final. |
79
|
| Method 'doAfterAuthorizationFailed' is not designed for extension - needs to be abstract, final or empty. |
88
|
| Missing a Javadoc comment. |
88
|
| Parameter action should be final. |
88
|
| Parameter mapping should be final. |
89
|
| Parameter form should be final. |
89
|
| Parameter request should be final. |
89
|
| Parameter response should be final. |
90
|
| Line is longer than 80 characters. |
93
|
| Method 'doBeforeAuthorization' is not designed for extension - needs to be abstract, final or empty. |
101
|
| Missing a Javadoc comment. |
101
|
| Parameter action should be final. |
101
|
| Parameter mapping should be final. |
101
|
| Parameter form should be final. |
102
|
| Parameter request should be final. |
102
|
| Parameter response should be final. |
103
|
org/saf/struts/util/SafContext.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Class SafContext should be declared as final. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Parameter authorizationManagerInterface should be final. |
28
|
| 'authorizationManagerInterface' hides a field. |
28
|
| Parameter config should be final. |
55
|
| 'config' hides a field. |
55
|
org/saf/struts/util/SafPluginUtils.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Utility classes should not have a public or default constructor. |
50
|
| Missing a Javadoc comment. |
51
|
| 'static' modifier out of order with the JLS suggestions. |
51
|
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
51
|
| Parameter config should be final. |
62
|
| Parameter action should be final. |
62
|
| Line is longer than 80 characters. |
64
|
| Line is longer than 80 characters. |
66
|
| Parameter config should be final. |
82
|
| Parameter action should be final. |
82
|
| Line is longer than 80 characters. |
85
|
| Line is longer than 80 characters. |
86
|
| Parameter request should be final. |
96
|
| Unused @param tag for 'config'. |
103
|
| Unused @param tag for 'action'. |
104
|
| Unused @param tag for 'methodName'. |
105
|
| Parameter request should be final. |
110
|
| Expected @param tag for 'request'. |
110
|
| Line is longer than 80 characters. |
113
|
| Missing a Javadoc comment. |
116
|
| Parameter config should be final. |
117
|
| Parameter mapping should be final. |
117
|
| Parameter action should be final. |
117
|
| Parameter methodName should be final. |
118
|
| Line is longer than 80 characters. |
125
|
| Line is longer than 80 characters. |
130
|
| Line is longer than 80 characters. |
136
|
| '&&' should be on a new line. |
138
|
| Line is longer than 80 characters. |
139
|
| Line is longer than 80 characters. |
140
|
| Parameter config should be final. |
158
|
| Parameter action should be final. |
158
|
| Parameter methodName should be final. |
159
|
| Line is longer than 80 characters. |
163
|
| '&&' should be on a new line. |
165
|
| Line is longer than 80 characters. |
166
|
| Line is longer than 80 characters. |
167
|
| Line is longer than 80 characters. |
169
|
| Parameter mapping should be final. |
187
|
| Parameter request should be final. |
188
|
| Line is longer than 80 characters. |
193
|
| Line is longer than 80 characters. |
195
|
| Parameter context should be final. |
220
|
| Parameter config should be final. |
221
|
| Parameter clazz should be final. |
221
|
| Line is longer than 80 characters. |
224
|
| Parameter context should be final. |
244
|
| Parameter config should be final. |
245
|
| Parameter clazz should be final. |
245
|
| '+' should be on a new line. |
253
|
| Parameter context should be final. |
271
|
| Parameter config should be final. |
272
|
| Parameter context should be final. |
301
|
| Parameter config should be final. |
301
|
| Line is longer than 80 characters. |
307
|
| '+' should be on a new line. |
307
|
| First sentence should end with a period. |
321
|
| Parameter context should be final. |
332
|
| Parameter config should be final. |
333
|
| Line is longer than 80 characters. |
334
|
| Parameter actionServlet should be final. |
357
|
| Parameter moduleConfig should be final. |
357
|
| Line is longer than 80 characters. |
360
|
| Line is longer than 80 characters. |
365
|
| Line is longer than 80 characters. |
369
|
| '+' should be on a new line. |
373
|
| Line is longer than 80 characters. |
376
|
| Line is longer than 80 characters. |
379
|
| Line is longer than 80 characters. |
385
|
| Line is longer than 80 characters. |
386
|
| Line is longer than 80 characters. |
389
|
| Line is longer than 80 characters. |
391
|
org/saf/struts/util/SafUtils.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Utility classes should not have a public or default constructor. |
28
|
| Missing a Javadoc comment. |
29
|
| 'static' modifier out of order with the JLS suggestions. |
29
|
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
29
|
| Parameter request should be final. |
41
|
| Parameter defId should be final. |
42
|
| Line is longer than 80 characters. |
53
|
| Parameter request should be final. |
76
|
| Parameter definition should be final. |
77
|
| Line is longer than 80 characters. |
94
|
| Parameter request should be final. |
119
|
| Line is longer than 80 characters. |
121
|
| Parameter request should be final. |
161
|
| Parameter defId should be final. |
161
|
| Line is longer than 80 characters. |
173
|
| Line is longer than 80 characters. |
181
|
| Line is longer than 80 characters. |
188
|
| Line is longer than 80 characters. |
189
|
| Line is longer than 80 characters. |
190
|
| Line is longer than 80 characters. |
191
|
| Line is longer than 80 characters. |
192
|
org/saf/struts/util/package.html
Error | Line |
| Missing package documentation file. | 0 |